feat(waf): Onboard Managed Rule Set#1594
Merged
Merged
Conversation
Manuelvaas
force-pushed
the
feature/waf-onboard-managed-rule-set
branch
from
July 17, 2026 08:39
754f80e to
2cb3a8e
Compare
SerseusWasTaken
left a comment
SerseusWasTaken
left a comment
Contributor
There was a problem hiding this comment.
The acc test fails for me with:
TF_ACC=1 go test -timeout=20m -v stackit/internal/services/albwaf/albwaf_acc_test.go
=== RUN TestAccManagedRuleSet
albwaf_acc_test.go:43: Step 1/4 error: Check failed: Check 2/5 error: stackit_alb_waf_managed_rule_set.managed_rule_set: Attribute 'region' expected "EU01", got "eu01"
panic.go:694: Error running post-test destroy, there may be dangling resources: getting resp: 400 Bad Request, status code 400, Body: {"code":3,"message":"one or more fields are invalid","details":[{"@type":"type.googleapis.com/google.rpc.BadRequest.FieldViolation","field":"region","description":"Expected region t
o be \"eu01\", but got \"EU01\"."}]}
--- FAIL: TestAccManagedRuleSet (1.44s)
FAIL
FAIL command-line-arguments 2.171s
FAIL
But i know some other tests don't run for me but which do for others, so maybe this is some weird issue with my machine again 🤔
Manuelvaas
force-pushed
the
feature/waf-onboard-managed-rule-set
branch
from
July 20, 2026 08:26
11f618b to
6276a8b
Compare
SerseusWasTaken
previously approved these changes
Jul 20, 2026
Merging this branch changes the coverage (1 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
SerseusWasTaken
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITTPR-716
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)